Merged
Conversation
kinow
reviewed
Oct 26, 2023
Member
kinow
left a comment
kinow
left a comment
There was a problem hiding this comment.
The code looks good, thanks for the cleanup and comments. Would a unit test be useful (or possible) here too?
Member
Author
|
Tests added. Largely, I'd coded around the problem by using "isRelative" and "! isRelative" but with tests the change is pushed down in jena-iri. I found this while comparing jena-iri with iri4ld and there'll be comparison tests for different |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #2060
This closes #2060
Various fixes in in ARP show that the change works. Several "isAbsolute" needed to be "!isRelative".
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.