Ensure .hashCode and .equals are both provided.#2166
Merged
afs merged 1 commit intoapache:mainfrom Jan 12, 2024
Merged
Conversation
kinow
approved these changes
Jan 11, 2024
Merged
TelicentPaul
approved these changes
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #2164, I tried some more IDE warning settings.
This PR is the result of missing
hashCode()when `.equals() is defined.Either it is autogenerated hashcod/equasl from Eclipse, or writing a hashCode function that agrees with the existing equals.
The fact some of the changes are in the code of Xerces datatype code copied into Jena is a little surprising.
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.