GH-2219 : Check for existence of Z axis and measure to avoid exception when neither is available#2231
Merged
afs merged 3 commits intoapache:mainfrom Feb 12, 2024
Merged
Conversation
Member
|
Could you add a test for this please? One place might be If nothing else, a new test class in |
- tests creation of coordinates for different combinations of spatial and measure dimension
Contributor
Author
|
I added a test class for the |
afs
requested changes
Feb 8, 2024
...src/test/java/org/apache/jena/geosparql/implementation/jts/CustomCoordinateSequenceTest.java
Show resolved
Hide resolved
| assertTrue(Double.isNaN(coord.getZ())); | ||
| assertEquals(2.0, coord.getM(), 0.001); | ||
| } | ||
| } No newline at end of file |
Member
|
Other than the license (and a minor issue format issue), this PR looks and builds properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #2219
Pull request Description:
Does fix an issue when Z axis isn't available.
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.