Merged
Conversation
kinow
approved these changes
Apr 20, 2024
| * This class is split out from {@link LogCtl} to decouple the dependencies. | ||
| * <p> | ||
| * This class is not used if log4j2 is not used. | ||
| * All logging initialization |
Member
There was a problem hiding this comment.
All logging initialization (….) ? Was reading it but the sentence suddenly ended ? 😬
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No functionality changes.
This is tidying the log4j control code, mainly to be careful to use the log4j API/SPI and not touch internals.
It is not clear how to test this in a way that does not risk disturbing logging in all other testing.
The code is changing the global, shared log4j setup.
Use of Log4j2 with Jena, including Fuseki, is optional. Any org.slf4j provider should work.
log4j2 is used by jena-cmds.
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.