Skip to content

Conversation

@afs
Copy link
Member

@afs afs commented Mar 9, 2018

Follow on from JENA-1503.

This splits up some TestTypeLiteral tests and removes the old testing for GregorianYear< 0 which didn't test correctly, and couldn't.

Copy link
Member

@ajs6f ajs6f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't tell what's going on here because of Git doing something really weird in terms of how it's calculating the diff... Did you add 18 new test methods, or just 1?

@afs
Copy link
Member Author

afs commented Mar 10, 2018

Added zero. I split one mega test (testDateTime) into parts. It was a sequence of independent parts. The same testing is done so that it is easier to work on any failures. testDateTime_9 contains a change - don't touch years < 0 because of the GregorianCalendar issue.

@ajs6f
Copy link
Member

ajs6f commented Mar 10, 2018

Ok, testDateTime_9 LGTM and if the others are just cut-and-paste, it should all be good.

@asfgit asfgit merged commit daf3490 into apache:master Mar 10, 2018
asfgit pushed a commit that referenced this pull request Mar 10, 2018
@afs afs deleted the test_tidy branch March 10, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants