GH-3844: Using JEP 394: Pattern Matching for instanceof for #equals in Node and Triple implementations#3846
Merged
arne-bdt merged 1 commit intoapache:mainfrom Apr 9, 2026
Conversation
…uals in Node and Triple implementations - Using JEP 394: Pattern Matching for instanceof for #equals in Node and Triple implementations
Member
|
FWIW The semantics changed; probably doesn't matter.
We could make the main RDF term / Node classes final (not this PR!). |
afs
approved these changes
Apr 9, 2026
Contributor
Author
|
@afs Should I have waited for a second approval? |
Member
|
No. Like all open source, resource is limited. If we were to wait, for a fixed number of approvals, we'd have a long backlog which causes its own problems and costs. We are also async - merging is where sync happens. In short - use your judgement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #3844
Pull request Description:
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
See the Apache Jena "Contributing" guide.