GH-3936: Check for trailing comma in JSON arrays for vars and bindings#3937
Open
afs wants to merge 1 commit into
Open
GH-3936: Check for trailing comma in JSON arrays for vars and bindings#3937afs wants to merge 1 commit into
afs wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved #3936
Pull request Description: as issue.
Trailing comma in head array can be a warning - it still finds the right variables - but a trailing comma in a result row does not show up so easily (it's a GSON syntax error) so that has to be a parsing error.
This PR does gives more relevant task-centric exception messages, not exceptions from deep inside GSON.
cc @Aklakan
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.