JENA-1519: OpWalkerVisitor with custom operators#394
JENA-1519: OpWalkerVisitor with custom operators#394asfgit merged 2 commits intoapache:masterfrom jeremy-coulon:bug-opext-jira-1519
Conversation
| @Override | ||
| protected void visitExt(OpExt op) { | ||
| before(op) ; | ||
| super.visitExt(op); |
There was a problem hiding this comment.
Not sure about this. It is visiting both the effective op and the real OpExt. Shoudn't it be the visitor deciding that? ie. visiting op.effectiveOp() is required?
There was a problem hiding this comment.
Visiting the real OpExt is not useful for me but I can't say for other people.
There was a problem hiding this comment.
There are probably both cases. Its an extension point so it is hard to be categorical. Only the effective is walkable unless the OpExt is comprised of known Ops in which case it does not need to be an OpExt.
Let's leave it as per the PR - we might have to return to it but without a concrete alternative usage, it feels like slipping towards guessing.
I would pull down the super impl and be explicit it walks the effectiveOp, not devolves the decision to the default method. This fixes the walker policy.
3 participants
No description provided.