JENA-901 Use Guava for cache, shadowed in jena-core#48
Closed
stain wants to merge 1 commit into
Closed
Conversation
this avoids adding a new module, so this is acceptable as a patch-version update.
Member
Author
|
I am closing this as the feedback on guava shadowed in jena-core was negative (and I agree!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In comparison with #47, this shadows Guava directly in
jena-corewithout introducingjena-shadowed-ext.This is thus acceptable as a patch-version update - but at the downside that
jena-corehave to dodirectly - while all other Jena modules would have to use
as it is shadowed with the JAR. This will cause problems in the other modules in an Eclipse-like environment, as the IDE will re-expose com.google version if
jena-coreis open - and they would then seemingly not be able to find theoaj.impl.ext.*version as that only exist in the Maven-built JAR.In this scenario, it would probably be cleaner for the other modules to also shadow guava - in addition to the space-wastage, this probably becomes a bit awkward - it also means you can't pass any Guava structures between Jena modules.
One advantage however is that if they all shadow individually, then they can shadow with the minimizeJar option to only get the few Guava classes used (e.g. in jena-core only the Cache).