Skip to content

Conversation

@jmkeil
Copy link
Contributor

@jmkeil jmkeil commented Sep 12, 2019

No description provided.

@afs afs requested a review from Claudenw September 13, 2019 11:04
@jmkeil
Copy link
Contributor Author

jmkeil commented Sep 18, 2019

Improved JavaDoc for ExprFactory and UpdateBuilder is still missing.

@jmkeil jmkeil changed the title JENA-1755: Improve documentation of Query Builders (initial attempts) JENA-1755: Improve documentation of Query Builders [WIP] Sep 18, 2019
@Claudenw
Copy link
Contributor

The changes are fine but I think that there might need to be more documentation in the package info describing things like how to get a ExprFactory and providing examples of how to use it.

@afs
Copy link
Member

afs commented Sep 22, 2019

@Claudenw - The 3.13.0 release approaches.

Is this ready to merge, and then add to package info later, or not merge and wait until there is a complete set of documentation upgrades?

If "ready to merge" could you, as reviewer, approve it, and ideally merge it?

@Claudenw Claudenw merged commit 2e2e33a into apache:master Sep 22, 2019
@afs
Copy link
Member

afs commented Sep 22, 2019

Thanks. JENA-1755 is still open to track any further changes.

@jmkeil jmkeil deleted the JENA-1755 branch January 6, 2022 11:31
@jmkeil jmkeil restored the JENA-1755 branch January 6, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants