JENA-1835: Capture and expose lexicalForm and dataType in DatatypeFormatException#686
Merged
afs merged 2 commits intoapache:masterfrom Feb 5, 2020
Merged
Conversation
rvesse
approved these changes
Feb 4, 2020
Member
rvesse
left a comment
rvesse
left a comment
There was a problem hiding this comment.
LGTM, one minor Javadoc typo to address
| /** | ||
| * The datatype that has an invalid lexical form. | ||
| * | ||
| * @return the datatype that this excpetion is related to. Maybe null depending on how the exception was constructed. |
Member
|
Recorded as https://issues.apache.org/jira/browse/JENA-1835, changed the PR title. @superfell - Is your JIRA id the same as GH? I see 4 JIRA accounts with the same name. |
afs
approved these changes
Feb 4, 2020
afs
changed the title
Contributor
Author
|
@afs My Jira username is sfell |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the TODO in this class.