JENA-1960: Clean up Fuseki dispatch#794
Conversation
|
|
||
| /** | ||
| * Old style compatibility. | ||
| * For each endpoint in "endpoints1", ensure there is a endpoint on the dataset 9endpoint name "") itself. |
There was a problem hiding this comment.
"an endpoint", and s/9endpoint/(endpoint.
rvesse
left a comment
rvesse
left a comment
There was a problem hiding this comment.
LGTM as far as I can follow the changes, some minor comment nits
| } | ||
|
|
||
| /** Register an addition assembler */ | ||
| /** Register an addition assembler */ |
| accEndpointOldStyle(endpoints1, Operation.GSP_R, fusekiService, pServiceReadGraphStoreEP); | ||
| accEndpointOldStyle(endpoints1, Operation.GSP_RW, fusekiService, pServiceReadWriteGraphStoreEP); | ||
|
|
||
| // ---- Legacy for old style: a request wouls also try the dataset (i.e. no endpoint name). |
| if ( endpoint == null ) | ||
| // Named service, no such endpoint. | ||
| // Allows for resources under /dataset/ | ||
| // Does to Jetty's default handling (404 for GET, 405 other methods). |
There was a problem hiding this comment.
This is actually out of date. This PR also changes the default handling of this case, replacing the Jetty default handling because Jetty is different to other servers.
| * nor that access control will allow it to be performed. | ||
| */ | ||
| public static Operation chooseOperation(HttpAction action) { | ||
| private static Operation chooseOperation(HttpAction action) { |
There was a problem hiding this comment.
Any particular reason to lock things down to private ?
There was a problem hiding this comment.
Only that this is an internal operation. From what I can tell, it is a left over from when dispatch was split across multiple classes.
afs
force-pushed
the
fuseki-new-config
branch
from
c4c5d8b to
506a188
Compare
afs
force-pushed
the
fuseki-new-config
branch
from
506a188 to
9c7aad3
Compare
Yes! Dispatch, in all its cases and all its extensibility is complicated. It's been though a number of rewrites. The test coverage is good and that has been essential in this PR which is a simplification of the dispatch process. Thanks to you both for looking. |
3 participants
Covers:
JENA-1960 Clean up Fuseki dispatch
and the small:
JENA-1961 Support /$/metrics in Fuseki Main
JENA-1962 Assembler for a dataset of a single graph taken from another dataset.