JENA-1950: Make GraalVM a test dependency#801
Merged
afs merged 1 commit intoapache:masterfrom Sep 25, 2020
Merged
Conversation
afs
approved these changes
Sep 25, 2020
afs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support custom SPARQL functions written in JavaScript, ARQ can interchangeably use Nashorn or Graal.js scripting engines (the former will be removed in JDK 15).
On JDK versions prior to JDK 15 ARQ can be compiled and used without any Graal-related dependencies.
On JDK 15 onward using JavaScript would require having org.graalvm.js:js and org.graalvm.js-scriptengine on the class path.
However, as Java Scripting API uses a SPI-based mechanism, they don't have to be included as compile-time dependencies.
They still need to be included as test dependencies to make it possible to compile ARQ on JDK 15+.
See also the discussion in #787