Merged
Conversation
kinow
approved these changes
Oct 1, 2020
| private static Server jettyServer(int port, boolean loopback) { | ||
| private static Server jettyServer(int port, boolean loopback, int minThreads, int maxThreads) { | ||
| ThreadPool threadPool = null; | ||
| // Jetty 9.4 : the Jetty default is200,8 |
Member
Author
There was a problem hiding this comment.
It really is 200,8 -- Jetty arguments are (max,min).
QueuedThreadPool.java in Jetty 9.4
One of the reasons for messing with this is that it becomes hard to debug with even the minimum 8 threads when you pause the whole JVM and want to find a thread in a particular state, especially if (for Delta testing) there are multiple Jetty servers in one JVM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.