Skip to content

[JENA-1985] Adding TriG and N-Quads content-type in Fuseki2.#817

Merged
afs merged 1 commit intoapache:masterfrom
marcelomachado:patch-1
Oct 22, 2020
Merged

[JENA-1985] Adding TriG and N-Quads content-type in Fuseki2.#817
afs merged 1 commit intoapache:masterfrom
marcelomachado:patch-1

Conversation

@marcelomachado
Copy link
Copy Markdown
Contributor

Jena already work with N-Quads and Trig serialization. This is also useful for dataset page on Fuseki Webpage.

Jena already work with N-Quads and Trig serialization. This is also useful for dataset page on Fuseki Webpage.
Copy link
Copy Markdown
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Would need to test it, but change is really simple. @marcelomachado we would need a JIRA too (if there's not one already), in order to include it in the changelog. Could you create one and update the title of the pull request with the JIRA ID?

https://issues.apache.org/jira/projects/JENA/issues

@afs
Copy link
Copy Markdown
Member

afs commented Oct 21, 2020

(Does not affect this PR)
when checking the details, I found some Java code constants for TriG make it look like the correct MIME type is text/trig, not application/trig. Both work through out the system so it's not observable - it's just the constant naming and Lang` definition. I'll tidy this up.

@marcelomachado marcelomachado changed the title Adding TriG and N-Quads content-type in Fuseki2. [JENA-1985] Adding TriG and N-Quads content-type in Fuseki2. Oct 21, 2020
@marcelomachado
Copy link
Copy Markdown
Contributor Author

Looks good to me. Would need to test it, but change is really simple. @marcelomachado we would need a JIRA too (if there's not one already), in order to include it in the changelog. Could you create one and update the title of the pull request with the JIRA ID?

https://issues.apache.org/jira/projects/JENA/issues

Done!

@afs afs merged commit 3f2d133 into apache:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants