HTTP Request : Improve responseMessage when resource download fails

[asfimport]

UbikLoadPack support (Bug 57696):
Hello,
When "Retrieve All Embedded Resources" is checked in HTTP Request and an error occurs in one of the download, the sampler is marked in error.

But when you use CSV output and show responseMessage, it is empty.
In this case it is difficult to know why sampler is in error as the responsr Message is empty.

It would be nice to add "Resource download failed" as message.

OS: All

[asfimport]

UbikLoadPack support (migrated from Bugzilla):
Created attachment BUG_57696.patch: Patch implementing enhancement

BUG_57696.patch

Index: src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
===================================================================
--- src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java	(revision 1664563)
+++ src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java	(working copy)
@@ -1383,6 +1383,7 @@
     private void setParentSampleSuccess(HTTPSampleResult res, boolean initialValue) {
         if(!IGNORE_FAILED_EMBEDDED_RESOURCES) {
             res.setSuccessful(initialValue);
+            res.setResponseMessage("Embedded resource download error"); //$NON-NLS-1$
         }
     }
 

[asfimport]

@pmouawad (migrated from Bugzilla):
Date: Sun Mar 22 14:04:11 2015
New Revision: 1668373

URL: http://svn.apache.org/r1668373
Log:
#3560 - HTTP Request : Improve responseMessage when resource download fails
#3560

Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
jmeter/trunk/xdocs/changes.xml

[asfimport]

@pmouawad (migrated from Bugzilla):
Date: Sun Mar 22 17:44:27 2015
New Revision: 1668420

URL: http://svn.apache.org/r1668420
Log:
#3560 - HTTP Request : Improve responseMessage when resource download fails
Oups : Fix test failure
#3560

Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java

[asfimport]

@pmouawad (migrated from Bugzilla):
Author: pmouawad
Date: Fri Jan 29 23:29:17 2016
New Revision: 1727663

URL: http://svn.apache.org/viewvc?rev=1727663&view=rev
Log:
#3560 HTTP Request : Improve responseMessage when resource download fails
#3560

Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java