NPE when opening a file after file system change

[asfimport]

Michael (Bug 63945):
If you navigate to File > Open in JMeter 5.2 and the directory in which the current file was opened no longer exists, you will get a null pointer exception. The full stack trace is below. I run into this issue when working with a Git repository that holds JMeter scripts. I will open a file, work with it, then switch branches to look at a different script and get the error shown below.

While this shouldn't matter, I am running JMeter under WSL in Windows 10, rather than the Windows 10 binary.

ERROR | Error processing org.apache.jmeter.gui.action.Load@76b224cd
java.lang.NullPointerException
at java.desktop/javax.swing.plaf.metal.MetalFileChooserUI$IndentIcon.getIconWidth(MetalFileChooserUI.java:971)
at java.desktop/javax.swing.SwingUtilities.layoutCompoundLabelImpl(SwingUtilities.java:1091)
at java.desktop/javax.swing.SwingUtilities.layoutCompoundLabel(SwingUtilities.java:1004)
at java.desktop/javax.swing.plaf.basic.BasicLabelUI.layoutCL(BasicLabelUI.java:103)
at java.desktop/javax.swing.plaf.basic.BasicLabelUI.getPreferredSize(BasicLabelUI.java:257)
at java.desktop/javax.swing.JComponent.getPreferredSize(JComponent.java:1680)
at com.bulenkov.darcula.ui.DarculaComboBoxUI.getSizeForComponent(DarculaComboBoxUI.java:129)
at java.desktop/javax.swing.plaf.basic.BasicComboBoxUI.getDisplaySize(BasicComboBoxUI.java:1409)
at java.desktop/javax.swing.plaf.basic.BasicComboBoxUI.getMinimumSize(BasicComboBoxUI.java:960)
at java.desktop/javax.swing.plaf.basic.BasicComboBoxUI.getPreferredSize(BasicComboBoxUI.java:949)
at java.desktop/javax.swing.JComponent.getPreferredSize(JComponent.java:1680)
at java.desktop/javax.swing.plaf.metal.MetalFileChooserUI$1.getPreferredSize(MetalFileChooserUI.java:246)
at java.desktop/java.awt.BorderLayout.preferredLayoutSize(BorderLayout.java:724)
at java.desktop/java.awt.Container.preferredSize(Container.java:1823)
at java.desktop/java.awt.Container.getPreferredSize(Container.java:1807)
at java.desktop/javax.swing.JComponent.getPreferredSize(JComponent.java:1682)
at java.desktop/java.awt.BorderLayout.preferredLayoutSize(BorderLayout.java:729)
at java.desktop/javax.swing.plaf.metal.MetalFileChooserUI.getPreferredSize(MetalFileChooserUI.java:622)
at java.desktop/javax.swing.JComponent.getPreferredSize(JComponent.java:1680)
at java.desktop/java.awt.BorderLayout.preferredLayoutSize(BorderLayout.java:724)
at java.desktop/java.awt.Container.preferredSize(Container.java:1823)
at java.desktop/java.awt.Container.getPreferredSize(Container.java:1807)
at java.desktop/javax.swing.JComponent.getPreferredSize(JComponent.java:1682)
at java.desktop/javax.swing.JRootPane$RootLayout.preferredLayoutSize(JRootPane.java:866)
at java.desktop/java.awt.Container.preferredSize(Container.java:1823)
at java.desktop/java.awt.Container.getPreferredSize(Container.java:1807)
at java.desktop/javax.swing.JComponent.getPreferredSize(JComponent.java:1682)
at java.desktop/java.awt.BorderLayout.preferredLayoutSize(BorderLayout.java:724)
at java.desktop/java.awt.Container.preferredSize(Container.java:1823)
at java.desktop/java.awt.Container.getPreferredSize(Container.java:1807)
at java.desktop/java.awt.Window.pack(Window.java:826)
at java.desktop/javax.swing.JFileChooser.createDialog(JFileChooser.java:819)
at java.desktop/javax.swing.JFileChooser.showDialog(JFileChooser.java:747)
at java.desktop/javax.swing.JFileChooser.showOpenDialog(JFileChooser.java:653)
at org.apache.jmeter.gui.util.FileDialoger.promptToOpenFile(FileDialoger.java:207)
at org.apache.jmeter.gui.util.FileDialoger.promptToOpenFile(FileDialoger.java:156)
at org.apache.jmeter.gui.util.FileDialoger.promptToOpenFile(FileDialoger.java:135)
at org.apache.jmeter.gui.util.FileDialoger.promptToOpenFile(FileDialoger.java:115)
at org.apache.jmeter.gui.action.Load.doActionAfterCheck(Load.java:76)
at org.apache.jmeter.gui.action.AbstractActionWithNoRunningTest.doAction(AbstractActionWithNoRunningTest.java:45)
at org.apache.jmeter.gui.action.ActionRouter.performAction(ActionRouter.java:88)
at org.apache.jmeter.gui.action.ActionRouter.lambda$actionPerformed$0(ActionRouter.java:70)
at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:313)
at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:770)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:715)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:740)
at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

Severity: normal
OS: All

[asfimport]

@FSchumacher (migrated from Bugzilla):
Thanks for the report. This seems to be a problem with JDK.

As a workaround, you can try to use another LAF than Metal in JMeter.

@team
While having a look at the code, I found a few places, where we look for the existence of the initial directory on which the file chooser should start.

I extended and simplified those occurrences and think I found a bug in the logic that chooses the initial location in FileDialoger#promptToOpenFile from line 177.

First we look, if existingFileName is pointing to something valid and use that as the initial location or the global initial location, if none location has been used before.

After that a bit further down, we test if a location has been used before and may initialize such a location.

Than -- and this is the potential bug -- we always use that location for the initial location of the file chooser.

Another dodgy logic is that we test for the default initial location in two different ways. First -- when no existingFileName is given -- we test for an empty default location and refuse to use it, if it is empty. The second time, we accept the default location, even if it is empty AND use it as the default location for the next runs.

[asfimport]

@FSchumacher (migrated from Bugzilla):
Created attachment filechooser.patch: Use a more consistent logic to choose initial dir for FileChooser

filechooser.patch

diff --git a/src/core/src/main/java/org/apache/jmeter/gui/util/FileDialoger.java b/src/core/src/main/java/org/apache/jmeter/gui/util/FileDialoger.java
index 23c795e..a8ad63e 100644
--- a/src/core/src/main/java/org/apache/jmeter/gui/util/FileDialoger.java
+++ b/src/core/src/main/java/org/apache/jmeter/gui/util/FileDialoger.java
@@ -180,18 +180,16 @@
        } else {
            jfc.setFileSelectionMode(JFileChooser.FILES_ONLY);
        }
-       if(!StringUtils.isEmpty(existingFileName)) {
-           File existingFileStart = new File(existingFileName);
-           if(existingFileStart.exists() && existingFileStart.canRead()) {
-               jfc.setCurrentDirectory(new File(existingFileName));
-           }
-       }
-       else if (lastJFCDirectory == null) {
+       if (!StringUtils.isEmpty(existingFileName)) {
+           setCurrentDirOnJFC(existingFileName);
+       } else if (lastJFCDirectory == null) {
            String start = System.getProperty("user.dir", ""); //$NON-NLS-1$//$NON-NLS-2$
 
            if (start.length() > 0) {
-               jfc.setCurrentDirectory(new File(start));
+               setCurrentDirOnJFC(start);
            }
+       } else {
+           setCurrentDirOnJFC(lastJFCDirectory);
        }
        clearFileFilters();
        if(exts != null && exts.length > 0) {
@@ -200,10 +198,6 @@
            jfc.setAcceptAllFileFilterUsed(true);
            jfc.setFileFilter(currentFilter);
        }
-       if(lastJFCDirectory==null) {
-           lastJFCDirectory = System.getProperty("user.dir", ""); //$NON-NLS-1$//$NON-NLS-2$
-       }
-       jfc.setCurrentDirectory(new File(lastJFCDirectory));
        int retVal = jfc.showOpenDialog(parentComponent);
        lastJFCDirectory = jfc.getCurrentDirectory().getAbsolutePath();
 
@@ -213,6 +207,13 @@
        return null;
    }
 
+    private static void setCurrentDirOnJFC(String currentDirName) {
+        File currentDir = new File(currentDirName);
+        if (currentDir.exists() && currentDir.canRead()) {
+            jfc.setCurrentDirectory(currentDir);
+        }
+    }
+
     private static void clearFileFilters() {
         FileFilter[] filters = jfc.getChoosableFileFilters();
         for (FileFilter filter : filters) {

[asfimport]

@FSchumacher (migrated from Bugzilla):
This problem -- I still think it is an JDK problem -- might be the cause for a few other reports that I found:

https://stackoverflow.com/questions/56928382/with-jmeter-5-1-1-r1855137-not-able-to-save-any-script-getting-exceptions-in-l
https://stackoverflow.com/questions/50097525/jmeter-4-0-unable-to-access-menus

[asfimport]

@FSchumacher (migrated from Bugzilla):
Created attachment filechooser.patch: Use a more consistent logic to choose initial dir for FileChooser

filechooser.patch

diff --git a/src/core/src/main/java/org/apache/jmeter/gui/util/FileDialoger.java b/src/core/src/main/java/org/apache/jmeter/gui/util/FileDialoger.java
index 23c795e144..7fb50bdf97 100644
--- a/src/core/src/main/java/org/apache/jmeter/gui/util/FileDialoger.java
+++ b/src/core/src/main/java/org/apache/jmeter/gui/util/FileDialoger.java
@@ -20,6 +20,7 @@ package org.apache.jmeter.gui.util;
 
 import java.awt.Component;
 import java.io.File;
+import java.util.Arrays;
 
 import javax.swing.JFileChooser;
 import javax.swing.filechooser.FileFilter;
@@ -27,6 +28,8 @@ import javax.swing.filechooser.FileFilter;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.jmeter.gui.GuiPackage;
 import org.apache.jmeter.gui.JMeterFileFilter;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * Class implementing a file open dialogue
@@ -39,6 +42,8 @@ public final class FileDialoger {
 
     private static JFileChooser jfc = new JFileChooser();
 
+    private static final Logger LOG = LoggerFactory.getLogger(FileDialoger.class);
+
     /**
      * Prevent instantiation of utility class.
      */
@@ -180,19 +185,7 @@ public final class FileDialoger {
        } else {
            jfc.setFileSelectionMode(JFileChooser.FILES_ONLY);
        }
-       if(!StringUtils.isEmpty(existingFileName)) {
-           File existingFileStart = new File(existingFileName);
-           if(existingFileStart.exists() && existingFileStart.canRead()) {
-               jfc.setCurrentDirectory(new File(existingFileName));
-           }
-       }
-       else if (lastJFCDirectory == null) {
-           String start = System.getProperty("user.dir", ""); //$NON-NLS-1$//$NON-NLS-2$
-
-           if (start.length() > 0) {
-               jfc.setCurrentDirectory(new File(start));
-           }
-       }
+       setCurrentDirOnJFC(existingFileName, lastJFCDirectory, System.getProperty("user.dir"));
        clearFileFilters();
        if(exts != null && exts.length > 0) {
            JMeterFileFilter currentFilter = new JMeterFileFilter(exts);
@@ -200,10 +193,6 @@ public final class FileDialoger {
            jfc.setAcceptAllFileFilterUsed(true);
            jfc.setFileFilter(currentFilter);
        }
-       if(lastJFCDirectory==null) {
-           lastJFCDirectory = System.getProperty("user.dir", ""); //$NON-NLS-1$//$NON-NLS-2$
-       }
-       jfc.setCurrentDirectory(new File(lastJFCDirectory));
        int retVal = jfc.showOpenDialog(parentComponent);
        lastJFCDirectory = jfc.getCurrentDirectory().getAbsolutePath();
 
@@ -213,6 +202,22 @@ public final class FileDialoger {
        return null;
    }
 
+    private static void setCurrentDirOnJFC(String... dirNames) {
+        for (String dirName : dirNames) {
+            if (StringUtils.isBlank(dirName)) {
+                continue;
+            }
+            File possibleDir = new File(dirName);
+            if (possibleDir.exists() && possibleDir.canRead()) {
+                jfc.setCurrentDirectory(possibleDir);
+                return;
+            }
+        }
+        LOG.info("No valid initial directory found for: {}",
+                    Arrays.asList(dirNames));
+        jfc.setCurrentDirectory(null);
+    }
+
     private static void clearFileFilters() {
         FileFilter[] filters = jfc.getChoosableFileFilters();
         for (FileFilter filter : filters) {

[asfimport]

@FSchumacher (migrated from Bugzilla):
@michael, could you test the next nightly, if this fixes your problem?

commit bfabdb8
AuthorDate: Sun Nov 24 11:33:32 2019 +0100

Use a sane initial dir for the file chooser

While having a look at 63945, I found a few places, where we look for the existence
of the initial directory on which the file chooser should start.

I extended and simplified those occurrences and think I found a bug in the logic that
chooses the initial location in FileDialoger#promptToOpenFile from line 177.

First we look, if existingFileName is pointing to something valid and use that as the
initial location or the global initial location, if none location has been used before.

After that a bit further down, we test if a location has been used before and may
initialize such a location.

Than -- and this is the potential bug -- we always use that location for the initial
location of the file chooser.

Another dodgy logic is that we test for the default initial location in two different ways.
First -- when no existingFileName is given -- we test for an empty default location and refuse
to use it, if it is empty. The second time, we accept the default location, even if it is
empty AND use it as the default location for the next runs.

https://github.com/apache/jmeter/issues/5202

---

.../org/apache/jmeter/gui/util/FileDialoger.java | 39 ++++++++++++----------
xdocs/changes.xml | 2 ++
2 files changed, 24 insertions(+), 17 deletions(-)

[asfimport]

@pmouawad (migrated from Bugzilla):
Hello Michael,
Any feedback please ?

Thank you

[asfimport]

Michael (migrated from Bugzilla):
(In reply to Philippe Mouawad from comment 6)

Hello Michael,
Any feedback please ?

Thank you

Sorry, just getting back to this after a space away.

I tried the most recent nightly (the 2020-03-06 build from https://ci.apache.org/projects/jmeter/nightlies/) and it fixed the problem I was having. After creating a test repo and deleting the directory, the open dialog moved up the tree to a directory that did still exist.

[asfimport]

@FSchumacher (migrated from Bugzilla):
Thanks for confirming, that the problem is fixed for you.