ThreadGroup; enter non-numeric throws NumberFormatException

[asfimport]

khammond25 (Bug 3627):
For the ThreadGroup element, if you enter a non-numeric in the "Number of
Threads" field, a java.lang.NumberFormatException error is thrown.

Severity: normal
OS: All

[asfimport]

khammond25 (migrated from Bugzilla):
Also, a java.lang.NumberFormatException can be thrown when editing the field.

For example, enter 5 in the "Number of Threads" field. Next, use the BACKSPACE
key to delete 5 and enter 3. When you deleted 5, the field was automatically
converted to a number. Of course, the field was empty because we just deleted
the 5. So, an exception was thrown.

[asfimport]

khammond25 (migrated from Bugzilla):
Also, if you enter a number that exceeds the maximum allowable integer, you get
a java.lang.NumberFormatException.

[asfimport]

khammond25 (migrated from Bugzilla):
Created attachment patch.ThreadGroup.diff: Patch for ThreadGroup.java; file contains the diff

patch.ThreadGroup.diff

--- \jakarta-jmeter-cvs\jakarta-jmeter\src\org\apache\jmeter\threads\ThreadGroup.java	Thu Aug 30 17:19:04 2001
+++ \jakarta-jmeter-nightly\2001.09.15\jakarta-jmeter\src\org\apache\jmeter\threads\ThreadGroup.java	Tue Sep 18 13:23:18 2001
@@ -83,11 +83,13 @@
 	LoopController control;
 	List listeners = new LinkedList();
 	List remoteListeners = new LinkedList();
-	int numThreads = 1;
+	private final int DEFAULT_NUM_THREADS = 1;
+	private final int DEFAULT_RAMP_UP = 0;
+	int numThreads = DEFAULT_NUM_THREADS;
 	List timers = new LinkedList();
 	private String name;
 	private SampleQueue queue = null;
-	int rampUp = 0;
+	int rampUp = DEFAULT_RAMP_UP;
 	private int threadsStarted = 0;
 
 	private static List addableList;
@@ -199,6 +201,26 @@
 	public int getNumThreads()
 	{
 		return this.numThreads;
+	}
+
+	/************************************************************
+	 *  !ToDoo (Method description)
+	 *
+	 *@return    !ToDo (Return description)
+	 ***********************************************************/
+	public int getDefaultNumThreads()
+	{
+		return this.DEFAULT_NUM_THREADS;
+	}
+
+	/************************************************************
+	 *  !ToDoo (Method description)
+	 *
+	 *@return    !ToDo (Return description)
+	 ***********************************************************/
+	public int getDefaultRampUp()
+	{
+		return this.DEFAULT_RAMP_UP;
 	}
 
 	public synchronized void resetThreadCount()

[asfimport]

khammond25 (migrated from Bugzilla):
Created attachment patch.ThreadGroupGui.diff: Patch for ThreadGroupGui.java; file contains the diff

patch.ThreadGroupGui.diff

--- \jakarta-jmeter-cvs\jakarta-jmeter\src\org\apache\jmeter\threads\gui\ThreadGroupGui.java	Fri Aug 31 00:46:46 2001
+++ \jakarta-jmeter-nightly\2001.09.15\jakarta-jmeter\src\org\apache\jmeter\threads\gui\ThreadGroupGui.java	Tue Sep 18 13:44:26 2001
@@ -142,7 +142,32 @@
 		}
 		else if (field.equals(THREAD_NAME))
 		{
-			model.setNumThreads(Integer.parseInt(threadInput.getText()));
+			try
+			{
+				model.setNumThreads(Integer.parseInt(threadInput.getText()));
+			}
+			catch (NumberFormatException nfe)
+			{
+				if (threadInput.getText().length() > 0)
+				{
+					JOptionPane.showMessageDialog(this, "You must enter a valid number",
+							"Invalid data", JOptionPane.WARNING_MESSAGE);
+					model.setNumThreads(model.getDefaultNumThreads());
+
+					// Right now, the cleanest thing to do is simply clear the 
+					// entire text field. We do not want to set the text to
+					// the default because that would be confusing to the user.
+					// For example, the user typed "5t" instead of "56". After
+					// the user closes the error dialog, the text would change
+					// from "5t" to "1".  A litle confusing. If anything, it
+					// should display just "5". Future enhancement...
+					threadInput.setText("");
+				}
+				else
+				{
+					model.setNumThreads(model.getDefaultNumThreads());
+				}
+			}
 		}
 		else if (field.equals(RAMP_NAME))
 		{
@@ -152,10 +177,19 @@
 			}
 			catch (NumberFormatException nfe)
 			{
-				// Ignore - only set value if valid
+				if (rampInput.getText().length() > 0)
+				{
+					JOptionPane.showMessageDialog(this, "You must enter a valid number",
+							"Invalid data", JOptionPane.WARNING_MESSAGE);
+					model.setRampUp(model.getDefaultRampUp());
+					rampInput.setText("");
+				}
+				else
+				{
+					model.setRampUp(model.getDefaultRampUp());
+				}
 			}
 		}
-
 	}
 
 	/************************************************************

[asfimport]

khammond25 (migrated from Bugzilla):
The two patches fix all parts of this bug. Additionally, a dialog is displayed
if the user enters an invalid number. With the patches for this bug and bug
#3682, the entire ThreadGroup Control Panel has a consistent behavior and is
much firendlier to the user!

Patch for ThreadGroup

I added default "number of threads" and "ramp up". This way, if the gui
detects an invalid number, it can ask the ThreadGroup for the default value.

Patch for ThreadGroupGui

Catch NumberFormatException and inform user of error in a dialog.

[asfimport]

khammond25 (migrated from Bugzilla):
Fixed 2001.09.27.

[asfimport]

Jordi Salvat i Alabart (migrated from Bugzilla):
Marking all bugs RESOLVED before JMeter 1.8's release date as VERIFIED.
Yes, it's pretty poor QA procedure, but there's bugs here lingering since JMeter
1.6, and we need to clean up a little.

[asfimport]

Jordi Salvat i Alabart (migrated from Bugzilla):
Bulk-closing all bugs RESOLVED before JMeter 1.8 release date.