Skip to content

Improved PR template#326

Closed
ham1 wants to merge 1 commit intoapache:trunkfrom
ham1:pr_template_updates
Closed

Improved PR template#326
ham1 wants to merge 1 commit intoapache:trunkfrom
ham1:pr_template_updates

Conversation

@ham1
Copy link
Contributor

@ham1 ham1 commented Nov 10, 2017

Description

Removed checkboxes from items which don't all have to be checked.
Added link to code style guidelines (the wiki page should be further updated).

@codecov-io
Copy link

Codecov Report

Merging #326 into trunk will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##              trunk     #326      +/-   ##
============================================
+ Coverage     57.74%   57.75%   +<.01%     
- Complexity     9913     9914       +1     
============================================
  Files          1139     1139              
  Lines         73051    73051              
  Branches       7303     7303              
============================================
+ Hits          42185    42190       +5     
+ Misses        28393    28389       -4     
+ Partials       2473     2472       -1
Impacted Files Coverage Δ Complexity Δ
...c/core/org/apache/jmeter/reporters/Summariser.java 84.61% <0%> (-0.77%) 17% <0%> (-1%)
...apache/jmeter/extractor/TestBoundaryExtractor.java 97.88% <0%> (ø) 17% <0%> (ø) ⬇️
...mpler/hc/JMeterPoolingClientConnectionManager.java 30.95% <0%> (+3.17%) 11% <0%> (+1%) ⬆️
...s/org/apache/jmeter/timers/PoissonRandomTimer.java 78.37% <0%> (+5.4%) 10% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55d3ad...84c19f0. Read the comment docs.

@ham1
Copy link
Contributor Author

ham1 commented Nov 10, 2017

How can this PR affect code coverage? Do we have tests which are non-deterministic and then change the test coverage each run?

@asfgit asfgit closed this in e02d949 Nov 10, 2017
@ham1 ham1 deleted the pr_template_updates branch November 12, 2017 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants