Cleanup saveservice#409
Closed
FSchumacher wants to merge 5 commits intoapache:trunkfrom
FSchumacher:cleanup-saveservice
Closed
Cleanup saveservice#409FSchumacher wants to merge 5 commits intoapache:trunkfrom FSchumacher:cleanup-saveservice
FSchumacher wants to merge 5 commits intoapache:trunkfrom
FSchumacher:cleanup-saveservice
Conversation
Contributor
|
+1 |
asfgit
pushed a commit
that referenced
this pull request
Oct 15, 2018
part of #409 on github git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1843938 13f79535-47bb-0310-9956-ffa450edef68
asfgit
pushed a commit
that referenced
this pull request
Oct 15, 2018
part of #409 on github git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1843940 13f79535-47bb-0310-9956-ffa450edef68
asfgit
pushed a commit
that referenced
this pull request
Oct 15, 2018
part of #409 on github git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1843941 13f79535-47bb-0310-9956-ffa450edef68
asfgit
pushed a commit
that referenced
this pull request
Oct 15, 2018
part of #409 on github git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1843943 13f79535-47bb-0310-9956-ffa450edef68
asfgit
pushed a commit
that referenced
this pull request
Oct 16, 2018
Followup to r1843941. Relates to #409. git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1844035 13f79535-47bb-0310-9956-ffa450edef68
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
part of apache#409 on github git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1843938 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 0e941d0
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
part of apache#409 on github git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1843940 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 1ec8328
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
part of apache#409 on github git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1843941 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 7ac8266
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
part of apache#409 on github git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1843943 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 28d95e4
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Closes apache#409 on github git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1843944 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 28397e4
StorDm
pushed a commit
to etnetera/jmeter
that referenced
this pull request
Jan 7, 2021
Followup to r1843941. Relates to apache#409. git-svn-id: https://svn.apache.org/repos/asf/jmeter/trunk@1844035 13f79535-47bb-0310-9956-ffa450edef68 Former-commit-id: 487acf8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cleanup code in
SaveService.Motivation and Context
I always like to look at the warnings in the IDE to see, where the code has problems. If there are too many warnings, I tend to oversee the real dangerous ones. So this pull request tries to get rid of the ones that are easy to fix and hopefully clearer to read.
How Has This Been Tested?
Ran the unit tests.
Screenshots (if appropriate):
Types of changes
Checklist: