chore: deprecate usage of Oro and switch default regex usage to JDKs#6661
Open
FSchumacher wants to merge 1 commit intoapache:masterfrom
Open
chore: deprecate usage of Oro and switch default regex usage to JDKs#6661FSchumacher wants to merge 1 commit intoapache:masterfrom
FSchumacher wants to merge 1 commit intoapache:masterfrom
Conversation
FSchumacher
force-pushed
the
disable-oro
branch
3 times, most recently
from
4112fee to
fe628e2
Compare
Contributor
Author
|
I wonder, if the change in the oro-regex-escape function is really useful, or if we should deprecate it. Mainly, because the name oro is so prominently placed in the functions name, not because the functionality is not useful. |
FSchumacher
force-pushed
the
disable-oro
branch
from
fe628e2 to
d44cf7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As started with JMeter 5.5 continue our deprecation of Oro as Regex implementation and switch to JDKs implementation by default. Users can switch back to Oro, if they want.
Motivation and Context
Oro has been deprecated for a long time and we want to remove it from our code base (see for example #6645)
How Has This Been Tested?
Tests have been already in place to support both implementations. This PR is mostly a cosmetic PR, where the default implementation is switched, some docs have been rewritten.
Screenshots (if appropriate):
Types of changes
Checklist: