i18n: drop ? from checkbox labels across all locales#6707
Open
vlsi wants to merge 1 commit into
Open
Conversation
vlsi
force-pushed
the
i18n-drop-checkbox-question-marks
branch
2 times, most recently
from
e66ca98 to
6c4b4d8
Compare
Follow-up to 9aa4e54 (ru). The same 27 resourceids render as checkboxes (and two boolean table-column headers, encode? and include_equals) in every locale, so the trailing `?` is dropped in en, de, es, fr, ja, ko, pl, pt_BR, tr, zh_CN, zh_TW. Spanish also loses the opening `¿`; the CJK files lose the full-width `？`. Two more messages checkboxes carried a `?` only in the French value while English was already clean: clear_cache_each_iteration (DNSCachePanel) and proxy_regex (ProxyControlGui). TestBean components were missed by the messages-only walk. The boolean properties below render as checkboxes, so their `.displayName` labels and `.shortDescription` tooltips drop the `?` too (es `¿…?`, CJK `？` handled as well): * CSVDataSet: recycle, stopThread, quotedData * RandomVariableConfig: perThread * DebugSampler / DebugPostProcessor: displayJMeterProperties, displayJMeterVariables, displaySamplerProperties, displaySystemProperties Strings phrased as full questions rather than a statement plus `?` are reworded to declarative form: the CJK messages keys (clear_cookies_per_iter ja, if_controller_evaluate_all ko, ldap_trust_all ko), the German Debug tooltips, the CSVDataSet recycle/stopThread/quotedData tooltips in en/de/es/fr/ko/pl/tr/zh_CN, and two non-dialog labels where one locale had added a question: include_path (de, FilePanel) and sampler_on_error_action (pl, TitledBorder). Question marks are kept where they belong: dialog confirms and titles (save?, revert_project?, template_load?, cancel_*, remove_confirm_*, should_save, web_parameters_lost_message, ask_existing_file, schematic_view_outputfile), the help_node menu item and property_returnvalue_param description, and the literal `?` in the Bolt URI example. The user manual (component_reference.xml and two build-*.xml tutorials) is synced to the new labels; changes_history is left untouched. The encode? key name is untouched; only its value changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vlsi
force-pushed
the
i18n-drop-checkbox-question-marks
branch
from
6c4b4d8 to
b047959
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drop the trailing question mark from checkbox labels (and two boolean table-column headers) in every locale:
en,de,es,fr,ja,ko,pl,pt_BR,tr,zh_CN,zh_TW. This covers the same 27 resourceids that lost their?in the Russian translation in 9aa4e54.¿so no unmatched mark is left behind.？(U+FF1F); that is removed too.ja clear_cookies_per_iter,ko if_controller_evaluate_all,ko ldap_trust_all.encode?key name is untouched; only its value changes.Why
A checkbox label is a statement, not a question. The trailing
?was an inconsistent carry-over from the original English strings (some even had a stray space before the mark). 9aa4e54 fixed this for Russian; this change applies the same convention to the remaining locales.How to verify
./gradlew :src:dist-check:testpasses (resource-bundle consistency check): 2103 tests, 0 failures.🤖 Generated with Claude Code