Conversation
|
Thanks for your PR.
|
|
Hi, @milamberspace I let you handle this. |
|
Hi! thanks for comments. |
|
@d0k1: You can modify your PR to include the comments above directly on your local branch, commit, squash your commits into one commit, push with --force option to update your PR on Github. |
There was a problem hiding this comment.
@d0k1 your PR have a bug: when the jsyntaxtextarea.font.size property is defined and jsyntaxtextarea.font.family is not defined, the size is not change on the textarea.
Probably, you must define the default value to "JSyntaxTextArea.getDefaultFont().getName()" the USER_FONT_FAMILY constants, and remove this if condition.
|
@d0k1 don't forget to ping me on github after the update of your PR. |
|
@milamberspace Thanks for pointing me a bug. I've fixed it, squashed all commits into one. |
|
@d0k1 Thanks for your improvement patch. Committed on jmeter repo, sorry for long delay for commit. |
No description provided.