JSPWIKI-1234 password reuse check #452
Open
+570
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…changing passwords. unfortunately unit tests are no longer stable, probably due to the user database change. pausing to work other issues
# Conflicts: # jspwiki-main/src/main/resources/CoreResources.properties # jspwiki-main/src/main/resources/CoreResources_de.properties # jspwiki-main/src/main/resources/CoreResources_es.properties # jspwiki-main/src/main/resources/CoreResources_fi.properties # jspwiki-main/src/main/resources/CoreResources_fr.properties # jspwiki-main/src/main/resources/CoreResources_it.properties # jspwiki-main/src/main/resources/CoreResources_nl.properties # jspwiki-main/src/main/resources/CoreResources_pt_BR.properties # jspwiki-main/src/main/resources/CoreResources_ru.properties # jspwiki-main/src/main/resources/CoreResources_zh_CN.properties # jspwiki-main/src/main/resources/ini/jspwiki.properties
…that use the xml database to be more ACID compliant. i.e. multiple test classes were working off the same file, by copying and randomizing the name, this guarantees that each unit test using the same file will not affect another
Contributor
Author
|
… the jdbc user database. fixes a logic issue in the jdbc setup, so the tests were worth the time
Contributor
Author
|
two API changes, UserProfile and UserDatabase. Adds a new method to support preventing password reuse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracks the last X password hashes to prevent reuse when changing passwords.