MINOR: Remove MemoryRecords.idempotentBuilder and replace its usage with MemoryRecords.builder #20503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary methods from MemoryRecord.
github-actions
bot
added
triage
chia7712
reviewed
Sep 9, 2025
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@Abyss-lord thanks for this patch. could you please also remove https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java#L505?
frankvicky
approved these changes
Sep 10, 2025
Contributor
frankvicky
left a comment
frankvicky
left a comment
There was a problem hiding this comment.
@Abyss-lord: LGTM.
Please address the comment from @chia7712
chia7712
approved these changes
Oct 31, 2025
chia7712
changed the title
Member
|
More cleanup can be addressed in the follow-up. I'm going to merge it |
eduwercamacaro
pushed a commit
to littlehorse-enterprises/kafka
that referenced
this pull request
Nov 12, 2025
…ith MemoryRecords.builder (apache#20503) This PR removes the redundant static method MemoryRecords.idempotentBuilder from MemoryRecords.java and updates its two usages in FetchRequestManagerTest.java and FetcherTest.java. Reviewers: TengYao Chi <frankvicky@apache.org>, Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the redundant static method
MemoryRecords.idempotentBuilder from MemoryRecords.java and updates its
two usages in FetchRequestManagerTest.java and FetcherTest.java.
Reviewers: TengYao Chi frankvicky@apache.org, Chia-Ping Tsai
chia7712@gmail.com