Skip to content

KAFKA-19699: improve the documentation of RecordsToDelete #20527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

KAFKA-19699: improve the documentation of RecordsToDelete #20527

merged 1 commit into from
Sep 17, 2025
+5 −3

Conversation

@DL1231
Copy link
Collaborator

@DL1231 DL1231 commented Sep 12, 2025 •
edited by github-actions bot
Loading

document the behavior of "-1" (HIGH_WATERMARK)

Reviewers: Ken Huang s7133700@gmail.com, TengYao Chi
kitingiao@gmail.com, Chia-Ping Tsai chia7712@gmail.com

@github-actions github-actions bot added triage PRs from the community clients small Small PRs labels Sep 12, 2025
frankvicky
frankvicky approved these changes Sep 14, 2025
View reviewed changes
Copy link
Contributor

@frankvicky frankvicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DL1231: LGTM

@github-actions github-actions bot removed the triage PRs from the community label Sep 15, 2025
m1a2st
m1a2st approved these changes Sep 17, 2025
View reviewed changes
Copy link
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@chia7712 chia7712 merged commit 9a32a71 into apache:trunk Sep 17, 2025
27 checks passed
jim0987795064 pushed a commit to jim0987795064/kafka that referenced this pull request Sep 25, 2025
@DL1231
KAFKA-19699 improve the documentation of RecordsToDelete (apache#20527
52766cb 
)

document the behavior of "-1" (HIGH_WATERMARK)

Reviewers: Ken Huang <s7133700@gmail.com>, TengYao Chi
 <kitingiao@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
eduwercamacaro pushed a commit to littlehorse-enterprises/kafka that referenced this pull request Nov 12, 2025
@DL1231 @eduwercamacaro
KAFKA-19699 improve the documentation of RecordsToDelete (apache#20527
b00091a 
)

document the behavior of "-1" (HIGH_WATERMARK)

Reviewers: Ken Huang <s7133700@gmail.com>, TengYao Chi
 <kitingiao@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chia7712 chia7712 chia7712 approved these changes

@frankvicky frankvicky frankvicky approved these changes

+1 more reviewer

@m1a2st m1a2st m1a2st approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-approved clients small Small PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DL1231 @chia7712 @frankvicky @m1a2st