MINOR: Improve consumer rebalance callbacks docs #20528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbejeck
approved these changes
Sep 12, 2025
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java
Outdated
Show resolved
Hide resolved
Member
Author
|
Thanks for the review @bbejeck ! All comments addressed. |
Member
Author
|
Thanks @bbejeck ! Fixed the flaky test. Now the 3 new tests pass consistently locally (tried up to ~50 and all ok, used to fail under 10 iterations before the fix). Will wait for the build and trigger a few to validate on CI too. |
jim0987795064
pushed a commit
to jim0987795064/kafka
that referenced
this pull request
Sep 25, 2025
Clarify rebalance callbacks behaviour (got some questions for onPartitionsAssigned, docs where indeed confusing about the partitions received in params). Reviewed all rebalance callbacks with it. Reviewers: Bill Bejeck<bbejeck@apache.org>
eduwercamacaro
pushed a commit
to littlehorse-enterprises/kafka
that referenced
this pull request
Nov 12, 2025
Clarify rebalance callbacks behaviour (got some questions for onPartitionsAssigned, docs where indeed confusing about the partitions received in params). Reviewed all rebalance callbacks with it. Reviewers: Bill Bejeck<bbejeck@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify rebalance callbacks behaviour (got some questions for
onPartitionsAssigned, docs where indeed confusing about the partitions
received in params). Reviewed all rebalance callbacks with it.
Reviewers: Bill Bejeckbbejeck@apache.org