MINOR: Update the delayed remote fetch purgatory cleanup comment #20721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
kamalcph
changed the title
Contributor
Author
showuon
reviewed
Oct 21, 2025
showuon
reviewed
Oct 21, 2025
Comment on lines
-1743
to
-1744
| // We only guarantee eventual cleanup via the next FETCH request for the same set of partitions or | ||
| // using reaper-thread. |
kamalcph
changed the title
kamalcph
commented
Oct 21, 2025
| val fetchPartitionData = localReadResults.map { case (tp, result) => | ||
| val remoteFetchResult = remoteFetchResults.get(tp) | ||
| if (remoteFetchInfos.containsKey(tp) | ||
| if (remoteFetchResults.containsKey(tp) |
Contributor
Author
There was a problem hiding this comment.
This change is minor one and required when enabling single-partition fetch. Let me know if you want to take this up in the next PR.
joshua2519
pushed a commit
to joshua2519/kafka
that referenced
this pull request
Oct 27, 2025
…che#20721) - Updated the delayed remote fetch purgatory cleanup comment Reviewers: Luke Chen <showuon@gmail.com>
eduwercamacaro
pushed a commit
to littlehorse-enterprises/kafka
that referenced
this pull request
Nov 12, 2025
…che#20721) - Updated the delayed remote fetch purgatory cleanup comment Reviewers: Luke Chen <showuon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: Luke Chen showuon@gmail.com