MINOR: Suppress warning logs for UnsupportedVersionException in ClientTelemetryReporter #20722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DL1231
changed the title
AndrewJSchofield
requested changes
Oct 17, 2025
| again. We may disconnect from the broker and connect to a broker that supports client | ||
| telemetry. | ||
| */ | ||
| boolean shouldWait = isRetryable(maybeFatalException); |
There was a problem hiding this comment.
Personally, I'd prefer to see
if (isRetryable(maybeFatalException))
There's no need for a shouldWait variable.
There was a problem hiding this comment.
And also, given that it's a RetriableException, why not isRetriable too?
| updateErrorResult(DEFAULT_PUSH_INTERVAL_MS, nowMs); | ||
| } else { | ||
| log.warn("Received unrecoverable error from broker, disabling telemetry"); | ||
| boolean shouldLog = shouldLog(maybeFatalException); |
There was a problem hiding this comment.
I would also just check maybeFatalException instanceof UnsupportedVersionException rather than hiding the check in a method. Do we really have to handle the case of the exception being wrapped by another exception?
chia7712
reviewed
Oct 21, 2025
There was a problem hiding this comment.
@DL1231 thanks for this fix.
@AndrewJSchofield Since KAFKA-19747 was merged into trunk, 4.1, and 4.0, this fix should be backported to those branches as well. WDYT?
chia7712
pushed a commit
that referenced
this pull request
Oct 22, 2025
…tTelemetryReporter (#20722) see https://github.com/apache/kafka/pull/20661/files#r2433576874 Suppress warning logs for `UnsupportedVersionException` in `ClientTelemetryReporter`. Reviewers: Andrew Schofield <aschofield@confluent.io>
chia7712
pushed a commit
that referenced
this pull request
Oct 22, 2025
…tTelemetryReporter (#20722) see https://github.com/apache/kafka/pull/20661/files#r2433576874 Suppress warning logs for `UnsupportedVersionException` in `ClientTelemetryReporter`. Reviewers: Andrew Schofield <aschofield@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/apache/kafka/pull/20661/files#r2433576874
Suppress warning logs for
UnsupportedVersionExceptioninClientTelemetryReporter.Reviewers: Andrew Schofield aschofield@confluent.io