KAFKA-19793 Adding allow topic creation false for global and restore consumer #20723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikita-Shupletsov
approved these changes
Oct 20, 2025
Contributor
Nikita-Shupletsov
left a comment
Nikita-Shupletsov
left a comment
There was a problem hiding this comment.
thank you for the PR.
LGTM. @mjsax Could you please take a look?
Contributor
Author
|
@mjsax Can you review the PR ? |
mjsax
reviewed
Oct 24, 2025
| baseConsumerProps.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "none"); | ||
|
|
||
| // disable auto topic creation | ||
| baseConsumerProps.put(ConsumerConfig.ALLOW_AUTO_CREATE_TOPICS_CONFIG, "false"); |
Member
There was a problem hiding this comment.
Why don't we add this to NON_CONFIGURABLE_CONSUMER_DEFAULT_CONFIGS and also set it centrally in getCommonConsumerConfigs() ?
For this case, we can also remove the corresponding line in getMainConsumerConfigs()
Contributor
Author
Hi @mjsax Can you also review and confirm ? |
mjsax
reviewed
Nov 5, 2025
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
Outdated
Show resolved
Hide resolved
mjsax
reviewed
Nov 6, 2025
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
Outdated
Show resolved
Hide resolved
mjsax
reviewed
Nov 6, 2025
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
Outdated
Show resolved
Hide resolved
…ectedUserSpecifiedClientConfig
mjsax
reviewed
Nov 6, 2025
streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java
Outdated
Show resolved
Hide resolved
mjsax
reviewed
Nov 6, 2025
streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java
Outdated
Show resolved
Hide resolved
mjsax
reviewed
Nov 6, 2025
| } | ||
|
|
||
| @Test | ||
| public void shouldLogErrorWhenUserTriesToOverrideAutoCreateTopics() { |
Member
There was a problem hiding this comment.
Should we also duplicate this test, using the three individual consumer prefix? (or just merge this test into the one from above?
Contributor
Author
There was a problem hiding this comment.
I have merge the test @mjsax Please review.
mjsax
approved these changes
Nov 10, 2025
Member
|
Thanks for the fix. Merged to |
eduwercamacaro
pushed a commit
to littlehorse-enterprises/kafka
that referenced
this pull request
Nov 12, 2025
…consumer (apache#20723) Added auto topic creation false for both restore and global consumers. Reviewers: Nikita Shupletsov <nshupletsov@confluent.io>, Matthias J. Sax <matthias@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added auto topic creation false for both restore and global consumers.
Reviewers: Nikita Shupletsov nshupletsov@confluent.io, Matthias J. Sax
matthias@confluent.io