Skip to content

Conversation

@majialoong
Copy link
Contributor

@majialoong majialoong commented Oct 19, 2025

Fix the usage of the subscribedTopicNames parameter in the
filterAssignedPartitions method to ensure correct partition filtering
based on the provided method argument.

Reviewers: Ken Huang s7133700@gmail.com, Kuan-Po Tseng
brandboat@gmail.com, Chia-Ping Tsai chia7712@gmail.com

@github-actions github-actions bot added triage PRs from the community group-coordinator small Small PRs labels Oct 19, 2025
@majialoong majialoong changed the title MINOR: Correct filterAssignedPartitions to use method parameter in ShareGroupAssignmentBuilder MINOR: Correct ShareGroupAssignmentBuilder#filterAssignedPartitions to use method parameter Oct 20, 2025
@AndrewJSchofield AndrewJSchofield self-requested a review October 20, 2025 09:38
@AndrewJSchofield AndrewJSchofield added KIP-932 Queues for Kafka ci-approved and removed triage PRs from the community labels Oct 20, 2025
Copy link
Member

@brandboat brandboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 merged commit 35bd71c into apache:trunk Oct 20, 2025
29 checks passed
@majialoong majialoong deleted the correct-filterAssignedPartitions-method branch October 21, 2025 14:07
eduwercamacaro pushed a commit to littlehorse-enterprises/kafka that referenced this pull request Nov 12, 2025
…o use method parameter (apache#20729)

Fix the usage of the `subscribedTopicNames` parameter in the
`filterAssignedPartitions` method to ensure correct partition filtering
based on the provided method argument.

Reviewers: Ken Huang <s7133700@gmail.com>, Kuan-Po Tseng
 <brandboat@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants