MINOR: make description more clear for group.protocol #20870
Merged
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
AndrewJSchofield
requested changes
Nov 12, 2025
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java
Outdated
Show resolved
Hide resolved
kirktrue
reviewed
Nov 13, 2025
Contributor
kirktrue
left a comment
kirktrue
left a comment
There was a problem hiding this comment.
Thanks for the PR @joel-hamill!
The proposed wording is more succinct, which is a win. Does it make sense to add some verbiage to point the user to the Consumer Rebalance Protocol section of the documentation?
AndrewJSchofield
approved these changes
Nov 13, 2025
Member
|
Build green apart from "Collate Test Catalog". |
shashankhs11
pushed a commit
to shashankhs11/kafka
that referenced
this pull request
Nov 14, 2025
Update the description for the group.protocol to correct grammar issues and make description more clear. Reviewers: Andrew Schofield <aschofield@confluent.io>, Kirk True <kirk@kirktrue.pro>
TaiJuWu
pushed a commit
to TaiJuWu/kafka
that referenced
this pull request
Dec 3, 2025
Update the description for the group.protocol to correct grammar issues and make description more clear. Reviewers: Andrew Schofield <aschofield@confluent.io>, Kirk True <kirk@kirktrue.pro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the description for the group.protocol to correct grammar issues
and make description more clear.
Reviewers: Andrew Schofield aschofield@confluent.io, Kirk True
kirk@kirktrue.pro