KAFKA-19286: Fix flaky testConcurrentRemoveReadForCache1 #20893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for flaky testConcurrentRemoveReadForCache1
Short description of root cause:
Before scheduler starts clean up, he's triggering read thread. If it's happening before RemoteIndexCache#remove does remove entity from cache, reader thread will successfully read entity, and won't trigger fetching from remote log
Full analysis:
https://issues.apache.org/jira/browse/KAFKA-19286
Evidence:
Run entire test class and annotate testConcurrentRemoveReadForCache1 as RepeatedTest to run 100_000 times
Result:
./gradlew storage:test --tests org.apache.kafka.storage.internals.log.RemoteIndexCacheTest...
BUILD SUCCESSFUL in 48m 11s