Skip to content

KAFKA-19924: Ensure deterministic task order by using TreeSet in TaskManager #20992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2025
Merged

KAFKA-19924: Ensure deterministic task order by using TreeSet in TaskManager #20992

merged 2 commits into from
Nov 26, 2025
+48 −33

Conversation

@shashankhs11
Copy link
Contributor

@shashankhs11 shashankhs11 commented Nov 25, 2025 •
edited by github-actions bot
Loading

Replace HashSet with TreeSet ordered by TaskId to ensure
deterministic processing order

Reviewers: Lucas Brutschy lbrutschy@confluent.io

@github-actions github-actions bot added triage PRs from the community streams small Small PRs labels Nov 25, 2025
This was referenced Nov 25, 2025
Merged
Open
@mjsax mjsax added ci-approved and removed triage PRs from the community labels Nov 26, 2025
@mjsax mjsax requested a review from lucasbru November 26, 2025 02:34
lucasbru
lucasbru approved these changes Nov 26, 2025
View reviewed changes
Copy link
Member

@lucasbru lucasbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lucasbru lucasbru merged commit c93e379 into apache:trunk Nov 26, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucasbru lucasbru lucasbru approved these changes

Assignees

No one assigned

Labels

ci-approved small Small PRs streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shashankhs11 @lucasbru @mjsax