KAFKA-19542: Consumer.close() does not remove all added sensors from Metrics #21038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Metrics The intention of the Consumer API is that after close(), metrics() should return an empty map of metrics. The lifecycle management of the various metrics managers in the consumer is inconsistent. Some managers remove all the metrics that were created, some registries remove some of them, and some don't make any effort to remove the metrics at all. This change introduces AbstractConsumerMetricsManager as a shared base class for consumer metrics managers, consolidating the steps of metric registration and cleanup logic, as well as unit tests to ensure that the different metrics managers perform the cleanup step.
chia7712
reviewed
Dec 2, 2025
| * This class should not be invoked directly; users should instead create a {@link KafkaConsumer} as before. | ||
| * This consumer implements the new consumer group protocol and is intended to be the default in coming releases. | ||
| */ | ||
| public class AsyncKafkaConsumer<K, V> implements ConsumerDelegate<K, V> { |
Member
There was a problem hiding this comment.
I assume this file was included by mistake 😄
Contributor
Author
There was a problem hiding this comment.
Yes. I removed the unintentionally-added file. Thanks for catching it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention of the
ConsumerAPI is that afterclose(),metrics()should return an empty map of metrics. The lifecycle management of the
various metrics managers in the consumer is inconsistent. Some managers
remove all the metrics that were created, some registries remove some of
them, and some don't make any effort to remove the metrics at all.
This change introduces
AbstractConsumerMetricsManageras a shared baseclass for consumer metrics managers, consolidating the steps of metric
registration and cleanup logic, as well as unit tests to ensure that the
different metrics managers perform the cleanup step.