MINOR: Deduplicate common test helpers in group-coordinator tests #21047
+451
−545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
dajac
reviewed
Dec 2, 2025
| } | ||
| } | ||
|
|
||
| protected def createTopicWithAdminRaw( |
Member
There was a problem hiding this comment.
We already have createTopic in this class. I wonder whether we could unify both. Have you checked by chance?
Contributor
Author
There was a problem hiding this comment.
We could use createTopic as well I believe, but that method waits for the metadata to propagate to all brokers. The helper we are introducing here (extracted from existing test usage) simply creates the topic and returns without waiting.
Contributor
Author
There was a problem hiding this comment.
Using createTopic now
| // in this test because it does not use FindCoordinator API. | ||
| createOffsetsTopic() | ||
|
|
||
| val admin = cluster.admin() |
Contributor
Author
There was a problem hiding this comment.
Ah, I missed removing it earlier. I have removed it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a helper method to create topics using the raw admin client
in
GroupCoordinatorBaseRequestTest. It also updates related tests touse the existing
createOffsetsTopichelper instead of manuallyduplicating topic-creation logic in multiple places. No functional
changes to test behavior.
Reviewers: David Jacot djacot@confluent.io