KAFKA-19957: Accumulate offsets response in same batch #21061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
AndrewJSchofield
approved these changes
Dec 3, 2025
Member
AndrewJSchofield
left a comment
AndrewJSchofield
left a comment
There was a problem hiding this comment.
Thanks for the PR. Looks good to me.
apoorvmittal10
added a commit
to apoorvmittal10/kafka
that referenced
this pull request
Dec 3, 2025
Merges contiguous AcquiredRecords with the same delivery count into single records. The PR accumulates multiple offsets in a single batch only if the offsets are part of same in-flight batch i.e. if cache has 0-4, and 5-9 and the records acquired are 3,4,5,6, with same delivery count, then output shall be [3-4],[5-6]. This has been done to make sure that offsets accumulation is not past the `batch size` in request. The in-flight batches originally formed on the broker are created as per the `batch size` from the client hence accumulating from single batch is safe. However, if in a same share group multiple clients request with different batch sizes then there would be discrepancy. Having said that, the similar problem might occur with complete batch acquisition in this case hence that should be fixed separately, if needed. Reviewers: Andrew Schofield <aschofield@confluent.io>
apoorvmittal10
added a commit
that referenced
this pull request
Dec 3, 2025
Merges contiguous AcquiredRecords with the same delivery count into single records. The PR accumulates multiple offsets in a single batch only if the offsets are part of same in-flight batch i.e. if cache has 0-4, and 5-9 and the records acquired are 3,4,5,6, with same delivery count, then output shall be [3-4],[5-6]. This has been done to make sure that offsets accumulation is not past the `batch size` in request. The in-flight batches originally formed on the broker are created as per the `batch size` from the client hence accumulating from single batch is safe. However, if in a same share group multiple clients request with different batch sizes then there would be discrepancy. Having said that, the similar problem might occur with complete batch acquisition in this case hence that should be fixed separately, if needed. Reviewers: Andrew Schofield <aschofield@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges contiguous AcquiredRecords with the same delivery count into
single records.
The PR accumulates multiple offsets in a single batch only if the
offsets are part of same in-flight batch i.e. if cache has 0-4, and 5-9
and the records acquired are 3,4,5,6, with same delivery count, then
output shall be [3-4],[5-6]. This has been done to make sure that
offsets accumulation is not past the
batch sizein request. Thein-flight batches originally formed on the broker are created as per
the
batch sizefrom the client hence accumulating from single batchis safe.
However, if in a same share group multiple clients request with
different batch sizes then there would be discrepancy. Having said that,
the similar problem might occur with complete batch acquisition in this
case hence that should be fixed separately, if needed.
Reviewers: Andrew Schofield aschofield@confluent.io