Implemented Kubernetes discovery in Cellar clusters.#2
Implemented Kubernetes discovery in Cellar clusters.#2pires wants to merge 3 commits intoapache:masterfrom pires:cellar_kubernetes
Conversation
There was a problem hiding this comment.
In case you're wondering, I've opened fabric8io/fabric8#3346
|
Cool, let me review this PR. |
|
@jbonofre @ANierbeck if you guys have nothing else to add, I believe this is ready. Care to merge? Thank you. |
|
It's in progress. I'm fixing a couple of minor stuff on it and adding some I tests. Sent from my Samsung Galaxy smartphone. -------- Original message -------- @jbonofre @ANierbeck if you guys have nothing else to add, I believe this is ready. Care to merge? Thank you. — |
|
whats the status on this? it looks kind of the same done in this commit!!!! |
|
it has been reviewed, applied and released. This PR can be closed. |
|
@jbonofre don't want to pick a fight here, but it's a little sad the commits have been re-authored. Contributing instructions say something about providing .patch and I asked you for the need of this. You said you were doing some work on it and it wasn't needed. But it seems there was almost none to none work made on top of my contribution :-( |
|
My bad: when I did the reply I applied your change on dedicated branch, that I cherry picked without commit. That's why I lost the original authoring. My apologise, I'm really sorry about that. |
4 participants
No description provided.