[KARAF-6797] More detailed description of the JAAS command options fo…#1142
Merged
jbonofre merged 1 commit intoapache:masterfrom Aug 10, 2020
Merged
[KARAF-6797] More detailed description of the JAAS command options fo…#1142jbonofre merged 1 commit intoapache:masterfrom
jbonofre merged 1 commit intoapache:masterfrom
Conversation
jbonofre
requested changes
Aug 10, 2020
| public class ManageRealmCommand extends JaasCommandSupport { | ||
|
|
||
| @Option(name = "--realm", description = "JAAS Realm", required = false, multiValued = false) | ||
| @Option(name = "--realm", description = "JAAS Realm. Must be combined with --module", required = false, multiValued = false) |
Member
There was a problem hiding this comment.
That's not fully correct. Realm can be combined with module, but also with index.
Contributor
Author
There was a problem hiding this comment.
Why should I combine this with index? Index is already a unique attribute.
Member
There was a problem hiding this comment.
Ah yes, my bad, I changed that. You are right.
| @Completion(RealmCompleter.class) | ||
| String realmName; | ||
|
|
||
| @Option(name = "--index", description = "Realm Index", required = false, multiValued = false) |
Member
There was a problem hiding this comment.
I would add the "must be combined" statement here and leave realm option description as it is.
jbonofre
approved these changes
Aug 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The option "--realm" of the command jaas:realm-manage have to be combine with the option "--module" and vice versa. This wasn't mentioned in the help message of the command.