Skip to content

KARAF-7155 - Deleting a factory configuration doesn't delete the associated json file#1379

Closed
jassuncao wants to merge 1 commit intoapache:mainfrom
jassuncao:KARAF-7155
Closed

KARAF-7155 - Deleting a factory configuration doesn't delete the associated json file#1379
jassuncao wants to merge 1 commit intoapache:mainfrom
jassuncao:KARAF-7155

Conversation

@jassuncao
Copy link

JsonConfigInstaller keeps tracks of configurations that are associated
to a json file. When the configuration is deleted it will try to delete
the file.

associated json file

JsonConfigInstaller keeps tracks of configurations that are associated
to a json file. When the configuration is deleted it will try to delete
the file.
@jbonofre jbonofre self-requested a review May 23, 2021 15:12
@jbonofre
Copy link
Member

jbonofre commented Jun 8, 2021

@jassuncao what about using felix.fileinstall.filename to delete the file ? This way we don't have to store the factory/pid in the map, just read the felix.fileinstall.filename from the properties and remove it.
It's the fix I did.
Thoughts ?

@jassuncao
Copy link
Author

@jbonofre I had the idea configuration properties wouldn't be available after receiving a ConfigurationEvent.CM_DELETED. I'm almost sure I attempted that, but I might have missed something,

@jbonofre
Copy link
Member

@jassuncao thanks, let me try something and I will let you know.

@jbonofre
Copy link
Member

Actually, it works for me.

@jbonofre jbonofre closed this Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants