Skip to content

Comments

KARAF-7282: fix autoRefresh setting treatment in Deployer#1456

Merged
jbonofre merged 1 commit intoapache:mainfrom
swachter:KARAF-7282
Nov 26, 2021
Merged

KARAF-7282: fix autoRefresh setting treatment in Deployer#1456
jbonofre merged 1 commit intoapache:mainfrom
swachter:KARAF-7282

Conversation

@swachter
Copy link
Contributor

@jbonofre jbonofre self-requested a review November 26, 2021 16:48
@jbonofre jbonofre merged commit 29e2f4b into apache:main Nov 26, 2021
@jbonofre
Copy link
Member

I reverted this change as the original code looks good to me.

@swachter
Copy link
Contributor Author

I do not understand why you reverted this. I tried the global setting autoRefresh=false and saw that auto refresh takes place nevertheless. Interestingly, PR#1457 seems to reintroduce the change.

@jbonofre
Copy link
Member

The original change breaks the build as the DeployerTest was not updated. In order to avoid to break all builds, I reverted and did a new fresh/clean PR with DeployerTest updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants