[KARAF-7317] Support spaces in boot features path#1477
Merged
jbonofre merged 1 commit intoapache:mainfrom Jan 6, 2022
Merged
Conversation
Author
|
I have created a companion ticket at KARAF-7317. |
jbonofre
approved these changes
Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URI.create(String)throws aURISyntaxExceptionif any of the resolved URIs fromfeaturesRepositoriescontains a space.This is common if customizing the boot features via the
karaf-maven-plugin, then running the assembly from within a path containing spaces.For example:
will result in a new feature in
etcas well as an entry inetc/org.apache.karaf.features.cfg:However, if
karaf.etccontains a space at runtime, Karaf fails to start because the URI cannot be parsed.This PR simply replaces all spaces with
%20before passing the path toURI.create(String). TheencodePathmethod can be further enhanced if other characters prove to be problematic.