Skip to content

[KARAF-7754] Require Java 11 at runtime/build time#1771

Closed
rovarga wants to merge 2 commits intoapache:mainfrom
rovarga:jdk11-rt
Closed

[KARAF-7754] Require Java 11 at runtime/build time#1771
rovarga wants to merge 2 commits intoapache:mainfrom
rovarga:jdk11-rt

Conversation

@rovarga
Copy link
Contributor

@rovarga rovarga commented Sep 22, 2023

This switches enforcer to require at least Java 11 at build-timetime and karaf's launch enforcement to require Java 11+ at run-time.

Enforce JVM version 11 on startup.

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
@rovarga rovarga changed the title Require Java 11 at runtime/build time KARAF-7754 Require Java 11 at runtime/build time Sep 22, 2023
@rovarga rovarga changed the title KARAF-7754 Require Java 11 at runtime/build time [KARAF-7754] Require Java 11 at runtime/build time Sep 22, 2023
@jbonofre jbonofre self-requested a review September 22, 2023 13:57
@jbonofre
Copy link
Member

Maybe we should change the javase version as well (in the karaf-maven-plugin and so).

@rovarga
Copy link
Contributor Author

rovarga commented Sep 22, 2023

Maybe we should change the javase version as well (in the karaf-maven-plugin and so).

Ah yes, I did not get that far. Since that is a run-time requirement, I am on the fence on that: it definitely has to be done at the latest when we switch to java.compiler.release to 11.

OTOH this PR unblocks things like Pax Web upgrade, so I'd like to keep its scope pretty much minimal.

@wborn
Copy link
Contributor

wborn commented Sep 23, 2023

There is also some logic in the karaf and karaf.bat scripts that can be simplified when Java 9+ is required.

@rovarga
Copy link
Contributor Author

rovarga commented Sep 24, 2023

There is also some logic in the karaf and karaf.bat scripts that can be simplified when Java 9+ is required.

You are right. As mentioned in the issue, we need to take a staggered approach here. I will split the effort accordingly.

@rovarga rovarga closed this Sep 24, 2023
@rovarga rovarga deleted the jdk11-rt branch September 24, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants