Closed
Conversation
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
oscerd
approved these changes
Sep 25, 2023
Member
|
It doesn't work for verify goal with this change. The verify mojo should be updated |
jbonofre
requested changes
Dec 17, 2023
Member
jbonofre
left a comment
jbonofre
left a comment
There was a problem hiding this comment.
We need a change on the karaf-maven-plugin:verify mojo to be able to deal with Java 11 kind packages.
Contributor
Author
|
Ah, yeah, I think this needs a lot more work. I will open a new PR once we are ready to take this step. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robert Varga robert.varga@pantheon.tech