Skip to content

karaf-maven-plugin: Remove try/catch blocks from tests #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jbonofre merged 1 commit into from
Sep 30, 2025
Merged

karaf-maven-plugin: Remove try/catch blocks from tests #2074

jbonofre merged 1 commit into from
Sep 30, 2025

Conversation

@holgerfriedrich
Copy link
Contributor

@holgerfriedrich holgerfriedrich commented Sep 29, 2025 •
edited
Loading

Error messages including the root cause are now being printed in case the test is failing.

Example error message when commons-lang3 version did not match the feature:

[INFO]   junit.framework.AssertionFailedError: org.custommonkey.xmlunit.Diff
[different] Expected text value 'mvn:org.apache.commons/commons-lang3/3.4' but was 'mvn:org.apache.commons/commons-lang3/3.18.0' - comparing <bundle ...>mvn:org.apache.commons/commons-lang3/3.4</bundle> at /features[1]/feature[1]/bundle[1]/text()[1] to <bundle ...>mvn:org.apache.commons/commons-lang3/3.18.0</bundle> at /features[1]/feature[1]/bundle[1]/text()[1]

@holgerfriedrich
karaf-maven-plugin: Remove try/catch blocks from tests
6947240 
Error messages including the root cause are now being printed in case the test is failing.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@jbonofre jbonofre self-requested a review September 30, 2025 05:55
@jbonofre jbonofre merged commit b217022 into apache:main Sep 30, 2025
1 check passed
jbonofre pushed a commit to jbonofre/karaf that referenced this pull request Sep 30, 2025
@holgerfriedrich @jbonofre
karaf-maven-plugin: Remove try/catch blocks from tests (apache#2074)
978f59a 
Error messages including the root cause are now being printed in case the test is failing.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich holgerfriedrich deleted the pr-tests branch September 30, 2025 16:29
jbonofre added a commit that referenced this pull request Oct 5, 2025
@jbonofre @holgerfriedrich
karaf-maven-plugin: Remove try/catch blocks from tests (#2074) (#2077)
764abe5 
Error messages including the root cause are now being printed in case the test is failing.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Co-authored-by: Holger Friedrich <mail@holger-friedrich.de>
MrEasy pushed a commit to seeburger-ag/karaf that referenced this pull request Nov 10, 2025
@jbonofre @holgerfriedrich @MrEasy
karaf-maven-plugin: Remove try/catch blocks from tests (apache#2074) (a…
1587a03 
…pache#2077)

Error messages including the root cause are now being printed in case the test is failing.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Co-authored-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbonofre jbonofre jbonofre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@holgerfriedrich @jbonofre