KARAF-4806: specify /bin/bash for scripts with bashisms #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client, instance and shell scripts use ulimit and type, but these are bashisms. In some environments (e.g. Solaris, Debian) /bin/sh isn't bash. Signed-off-by: Stephen Kitt <skitt@redhat.com> (cherry picked from commit 9e72b93)
Contributor
|
Usually the commit on master is backported on the older branches. So maybe this PRs on karaf-4.0.x and 3.0.x can be avoided. |
Member
|
Can you please close this PR ? Only a PR on master is required (github integration only consider master). Thanks ! |
ffang
pushed a commit
to ffang/karaf-1
that referenced
this pull request
Dec 9, 2018
[ENTESB-7611] Upgrade to org.apache.aries.transaction.jdbc-2.1.3 to e…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client, instance and shell scripts use ulimit and type, but these
are bashisms. In some environments (e.g. Solaris, Debian) /bin/sh
isn't bash.
Signed-off-by: Stephen Kitt skitt@redhat.com
(cherry picked from commit 9e72b93)