Skip to content

fix(karaf-maven-plugin): handle KAR files in features-generate-descriptor (4.4.x) #2577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbonofre merged 1 commit into from
Apr 24, 2026
Merged

fix(karaf-maven-plugin): handle KAR files in features-generate-descriptor (4.4.x) #2577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions ...-maven-plugin/src/main/java/org/apache/karaf/tooling/features/GenerateDescriptorMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

import java.io.*;
import java.nio.file.Files;
import java.util.zip.ZipEntry;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Comparator;
Expand Down Expand Up @@ -757,11 +758,44 @@ private Manifest getManifest(File file) {
static Features readFeaturesFile(File featuresFile) throws XMLStreamException, JAXBException, IOException {
if (JacksonUtil.isJson(featuresFile.toURI().toASCIIString())) {
return JacksonUtil.unmarshal(featuresFile.toURI().toASCIIString());
} else if (featuresFile.getName().endsWith(".kar")) {
return readFeaturesFromKar(featuresFile);
} else {
return JaxbUtil.unmarshal(featuresFile.toURI().toASCIIString(), false);
}
}

static Features readFeaturesFromKar(File karFile) throws IOException, XMLStreamException, JAXBException {
ObjectFactory objectFactory = new ObjectFactory();
Features merged = objectFactory.createFeaturesRoot();
merged.setName(karFile.getName());
try (JarInputStream jar = new JarInputStream(new FileInputStream(karFile))) {
ZipEntry entry;
while ((entry = jar.getNextEntry()) != null) {
String entryName = entry.getName();
if (!entry.isDirectory()
&& entryName.startsWith("repository/")
&& entryName.endsWith(".xml")
&& !new File(entryName).getName().startsWith("maven-metadata")) {
ByteArrayOutputStream baos = new ByteArrayOutputStream();
byte[] buf = new byte[8192];
int n;
while ((n = jar.read(buf)) != -1) {
baos.write(buf, 0, n);
}
try {
Features f = JaxbUtil.unmarshal(entryName, new ByteArrayInputStream(baos.toByteArray()), false);
merged.getFeature().addAll(f.getFeature());
merged.getRepository().addAll(f.getRepository());
} catch (Exception e) {
// Not a features XML, skip
}
}
}
}
return merged;
}

@Override
public void setLog(Log log) {
this.log = log;
Expand Down
Loading