EntrySet should be iterated when both the key and value are needed#346
Closed
apupier wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Member
|
R: @jbonofre |
jbonofre
approved these changes
Sep 6, 2017
Member
jbonofre
left a comment
jbonofre
left a comment
There was a problem hiding this comment.
It doesn't bring lot of value, but LGTM. I'm merging.
Contributor
Author
|
it brings performance value, it avoids to access and search two times in the map. it is making a visible effect for large Maps but i don't know which ones can be big or not. Please note that there are a lot more of this in the codebase. |
Member
|
FYI, the compiler (since Java 1.7 update 40) can already optimize the iteration on the map. Further more, those maps are pretty small ;) Thanks anyway ! |
Contributor
Author
|
@jbonofre do you have a reference link for that? i would like to report it to Sonar in order that they don't report it as an issue if source is requiring Java 7 |
Member
|
Let me find it. Anyway, I prefer your approach, it's clearer ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aurélien Pupier apupier@redhat.com