Speed up repository loading #366
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toLoad is used as a java.util.Queue, but is backed by an ArrayList, which is highly inefficient when large number of items are present. Turn it into a Queue with ArrayDeque as the implementation, which shaves OpenDaylight initial start time from 102 seconds down to under3 seconds. Signed-off-by: Robert Varga <nite@hq.sk>
Contributor
|
Awesome ! I'll commit it asap. |
Contributor
Author
|
Btw, downstream issue tracking this is: https://bugs.opendaylight.org/show_bug.cgi?id=9161 |
Contributor
|
Merged to master, 4.1.x and 4.0.x branches. Could you please close the PR ? |
Contributor
Author
|
Sure thing. It is also applicable to master (although the 'loaded' Set masks some of the performance impact). Should I push a PR for that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toLoad is used as a java.util.Queue, but is backed by an ArrayList,
which is highly inefficient when large number of items are present.
Turn it into a Queue with ArrayDeque as the implementation, which shaves
OpenDaylight initial start time from 102 seconds down to under3 seconds.
Signed-off-by: Robert Varga nite@hq.sk