DeployMojo fix ssh deploy#466
Merged
Merged
Conversation
jbonofre
requested changes
Feb 24, 2018
| } | ||
|
|
||
| final ClientChannel channel = session.createChannel("exec", print.toString().concat(NEW_LINE)); | ||
| final ClientChannel channel = session.createChannel("exec", writer.toString().concat(NEW_LINE)); |
Member
There was a problem hiding this comment.
Why using the writer whereas we have the printwriter ?
StringWriter writer = new StringWriter();
PrintWriter print = new PrintWriter(writer, true);
Author
There was a problem hiding this comment.
The PrintWriter doesn't override the toString method. So whenever deploying it would actually try to execute as it says in the ticket: KARAF-5642
Member
There was a problem hiding this comment.
Ok got it. So the consequence is a invalid string. Thx.
jbonofre
approved these changes
Mar 26, 2018
gnodet
pushed a commit
to gnodet/karaf
that referenced
this pull request
Mar 7, 2022
[ENTESB-16480] We need SMX version of the activation API...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: 5642